Add macOS .app bundle selection and launch support#9
Draft
Conversation
Claude
AI
changed the title
- Update folder selection dialog to allow selecting .app bundles on macOS - Update binary verifier to check inside .app/Contents/MacOS/ for executables - Update launcher to support macOS platform with correct working directory - Note: BepInEx injection for macOS not yet implemented (vanilla launch only) Co-authored-by: danielchim <12156547+danielchim@users.noreply.github.com>
danielchim
force-pushed
the
claude/add-macos-launch-support
branch
from
2839272 to
cece789
Compare
Owner
|
@AkaraChen please review the changes, if okay i will merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, users could not select .app bundles as the game install folder because the folder picker only accepted directories, and binary verification didn't check inside the bundle structure.
Changes
Folder selection dialog (
electron/main.ts,electron/trpc/router.ts)openFileproperty on macOS to allow selecting .app bundles (which appear as files but are directories)Binary verification (
electron/launch/binary-verifier.ts)Contents/MacOS/inside .app bundles for executables when install folder ends with.appGame launcher (
electron/launch/launcher.ts)cwdto parent directory for .app bundles (not the .app itself)Example
When selecting
Game.appas install folder withexeNames: ["Game.app"]:/path/to/Game.app/Contents/MacOS/Gamecwd: "/path/to"andexePath: "/path/to/Game.app/Contents/MacOS/Game"Supports macOS games in ecosystem:
CaL-ABP-macOS.app,LLBlaze.app,Hollow Knight Silksong.appOriginal prompt